-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add dependency on cordova-support-google-services #2293
Conversation
@macdonst let me know if I can help to update documentation. |
@chemerisuk thanks for the PR. I just merged it in. We should try and get as many people as possible to move to using your plugin as a dependency. Actually, we should probably make it an option you can enabled in |
@macdonst agree, It's hard to imagine modern Android development without having a dependency on google services. The advantage of gradle plugins is that they do not add extra code at runtime, so people that for a some reason do not have The only issue is compatibility with many existing plugins... On the other hand recent |
@chemerisuk You should try and spread that word on the cordova dev mailing list. We'll get broader opinions there. |
I agree with @fredgalvao, we should bring this to the cordova dev mailing list. What I envision is a preference like:
where the default it is Say this lands in cordova-android 8 then @chemerisuk can update the Also, @chemerisuk what do you mean by cordova-android 7 breaks plugins? |
@macdonst folder structure has changed and in many cases plugins must be updated because of that (read http://cordova.apache.org/announcements/2017/12/04/cordova-android-7.0.0.html#disqus_thread). As for preference
|
@chemerisuk I just sent a message out to the dev mailing list. Please chime in. |
@macdonst I have issue with connecting to that discussion... The only suggestion is to drop |
@chemerisuk sorry are you saying you can't participate in the discussion? With regards to the exact name of the preference I'm not worried about what it eventually gets called. |
@macdonst had problems with authentication, now resolved. |
@macdonst Just submitted PR at apache/cordova-android#438 |
This thread has been automatically locked. |
Adding dependency on cordova-support-google-services should resolve some conflicts.
Description
Per our discussion at chemerisuk/cordova-support-google-services#1 (comment).
Related Issue
chemerisuk/cordova-support-google-services#1
Motivation and Context
Solve compatibility issues between cordova plugins.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: