Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coin swap proof #74

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Coin swap proof #74

wants to merge 14 commits into from

Conversation

wqking
Copy link
Contributor

@wqking wqking commented Jun 26, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #74 into master will increase coverage by 0.46%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   49.84%   50.31%   +0.46%     
==========================================
  Files          38       39       +1     
  Lines        4261     4317      +56     
==========================================
+ Hits         2124     2172      +48     
- Misses       1878     1882       +4     
- Partials      259      263       +4
Impacted Files Coverage Δ
swap/coinswap.go 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55654fd...66c854e. Read the comment docs.

@meyer9
Copy link
Member

meyer9 commented Jun 27, 2019

Can you move this from misc into swap as the root folder?

@meyer9 meyer9 added the enhancement New feature or request label Sep 19, 2019
@meyer9
Copy link
Member

meyer9 commented Sep 19, 2019

We're going to save this code for when we actually want to start testing the migration, but I don't think we're at that point yet.

@meyer9 meyer9 added the on-hold label Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on-hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants