Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Refactor header dialogs (about, info, bug) to use Dialog class #130

Open
thinkh opened this issue Jan 4, 2021 · 0 comments · May be fixed by #131
Open

Refactor header dialogs (about, info, bug) to use Dialog class #130

thinkh opened this issue Jan 4, 2021 · 0 comments · May be fixed by #131
Assignees
@thinkh
Labels
type: refactor Refactor the current implementation

Comments

@thinkh
Copy link
Contributor

thinkh commented Jan 4, 2021

Currently, the dialog code is hard-coded as HTML template. Instead, the dialogs should open using the Dialog class. The goal is to provide more consistency over all dialogs and easier customization.
@thinkh thinkh added the type: refactor Refactor the current implementation label Jan 4, 2021
@thinkh thinkh self-assigned this Jan 4, 2021
thinkh added a commit that referenced this issue Jan 4, 2021
@thinkh
Refactor header dialogs
50a70dd 
Closes #130

* Remove hard-coded modal dialog HTML code
* Use Dialog class instead

Breaking changes might be:
* dialog id to class
   * `#headerAboutDialog` -> `.header-about-dialog`
   * `#headerReportBugDialog` -> `.header-report-bug-dialog`
   * `#headerOptionsDialog` -> `.header-options-dialog`
* Make link toggle functions private (`toggleOptionsLink`, `toggleReportBugLink`, `toggleHelpLink`)
* About dialog: `content` parameter of content generator function is now empty -> default HTML is only generated by `defaultAboutInfo()`
@thinkh thinkh linked a pull request Jan 4, 2021 that will close this issue
Draft
@thinkh thinkh linked a pull request Jan 4, 2021 that will close this issue
Refactor header dialogs (about, info, bug) to use Dialog class #131
Draft
@ghost ghost mentioned this issue Jun 4, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thinkh thinkh

Labels
type: refactor Refactor the current implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor header dialogs (about, info, bug) to use Dialog class phovea/phovea_ui
1 participant
@thinkh