This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Refactor header dialogs (about, info, bug) to use Dialog class #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #130 * Remove hard-coded modal dialog HTML code * Use Dialog class instead Breaking changes might be: * dialog id to class * `#headerAboutDialog` -> `.header-about-dialog` * `#headerReportBugDialog` -> `.header-report-bug-dialog` * `#headerOptionsDialog` -> `.header-options-dialog` * Make link toggle functions private (`toggleOptionsLink`, `toggleReportBugLink`, `toggleHelpLink`) * About dialog: `content` parameter of content generator function is now empty -> default HTML is only generated by `defaultAboutInfo()`
|
@anita-steiner and me decided to set this PR on hold for now as it might trigger some more changes in other apps. We might come back to this PR after the next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130
Summary
Breaking changes might be:
#headerAboutDialog->.header-about-dialog#headerReportBugDialog->.header-report-bug-dialog#headerOptionsDialog->.header-options-dialogtoggleOptionsLink,toggleReportBugLink,toggleHelpLink)contentparameter of content generator function is now empty -> default HTML is only generated bydefaultAboutInfo()