Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Refactor header dialogs (about, info, bug) to use Dialog class #131

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Refactor header dialogs (about, info, bug) to use Dialog class #131

wants to merge 1 commit into from

Commits on Jan 4, 2021

  1. Refactor header dialogs 

    Closes #130

* Remove hard-coded modal dialog HTML code
* Use Dialog class instead

Breaking changes might be:
* dialog id to class
   * `#headerAboutDialog` -> `.header-about-dialog`
   * `#headerReportBugDialog` -> `.header-report-bug-dialog`
   * `#headerOptionsDialog` -> `.header-options-dialog`
* Make link toggle functions private (`toggleOptionsLink`, `toggleReportBugLink`, `toggleHelpLink`)
* About dialog: `content` parameter of content generator function is now empty -> default HTML is only generated by `defaultAboutInfo()`
    @thinkh
    thinkh committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    50a70dd View commit details
    Browse the repository at this point in the history