Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add cursor for long request #10

Open
wants to merge 25 commits into
base: v0.2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
59dc7e2
Add logical cursor for long query parameters
JoMessina Dec 7, 2023
e7db160
fix type phpstan, manage api return's cursor with the array of parame…
JoMessina Dec 8, 2023
cb0cc3e
remove IGNORE_ENV_TRUE parameter for cs-fixer
JoMessina Dec 8, 2023
2b2443f
Ignore a rule from phpstan
JoMessina Jan 9, 2024
a3cae97
fix from cs fixer
JoMessina Jan 9, 2024
49487d4
change phpstan config for level 5
JoMessina Jan 9, 2024
1deb047
Change a method name
JoMessina Jan 9, 2024
7739f08
Refactored the way filters are handled
gplanchat Jan 18, 2024
fa3110f
[rector] Rector fixes
actions-user Jan 18, 2024
8557f04
refacto extractors, add withGroups and withFilters methods
JoMessina Jan 19, 2024
76e3b15
manage page count, fix extractor to use api pagination
JoMessina Jan 23, 2024
1bf121b
fix and add tests for extractors
JoMessina Jan 24, 2024
6d22048
[rector] Rector fixes
actions-user Jan 24, 2024
68b0dae
Refactored the way filters are handled
gplanchat Jan 30, 2024
b9ba56b
Fixed errors in the unit tests
gplanchat Jan 30, 2024
ef45ba6
Fix client api version to 2.4
JoMessina Jan 30, 2024
c67ad88
[rector] Rector fixes
actions-user Jan 31, 2024
b110c44
Changed the variadic methods to use array_push instead of foreach
gplanchat Jan 30, 2024
3c3a255
Merge remote-tracking branch 'origin/feature/add-cursor-for-long-requ…
JoMessina Jan 31, 2024
77b53da
Fix client api version to 2.4
JoMessina Jan 31, 2024
1ebac38
fix annotations for phpstan, fix endpoints on tests
JoMessina Feb 2, 2024
bcd3480
[rector] Rector fixes
actions-user Feb 2, 2024
9dd01d1
lock symfony serializer package, symfony 7 change an interface Denorm…
JoMessina Feb 8, 2024
602af15
update api-client-magento to lock symfony/serializer
JoMessina Feb 9, 2024
9e44dc2
valid phpstan 7, use rector and cs-fixer
JoMessina Feb 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .github/workflows/phpstan-7.yaml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: PHPStan level 6
name: PHPStan level 9
on: push
jobs:
phpstan:
phpstan-9:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -20,4 +20,4 @@ jobs:
uses: php-actions/phpstan@v3
with:
path: src/
level: 6
level: 9
37 changes: 18 additions & 19 deletions .github/workflows/quality.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Quality (PHPStan lvl 4)
name: Quality (PHPStan lvl 7)
on: push
jobs:
cs-fixer:
Expand All @@ -12,25 +12,24 @@ jobs:
run: |
wget -q https://cs.symfony.com/download/php-cs-fixer-v3.phar -O php-cs-fixer
chmod a+x php-cs-fixer
PHP_CS_FIXER_IGNORE_ENV=true ./php-cs-fixer fix src --dry-run
./php-cs-fixer fix src --dry-run

phpstan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/cache@v3
with:
path: '**/vendor'
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-
- uses: php-actions/composer@v6
with:
args: --prefer-dist
php_version: '8.2'

- name: PHPStan
uses: php-actions/phpstan@v3
with:
path: src/
level: 4
- uses: actions/checkout@v3
- uses: actions/cache@v3
with:
path: '**/vendor'
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-
- uses: php-actions/composer@v6
with:
args: --prefer-dist
php_version: '8.2'
- name: PHPStan
uses: php-actions/phpstan@v3
with:
path: src/
level: 7
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"psr/log": "^3.0",
"nyholm/psr7": "^1.5",
"php-etl/bucket": "*",
"php-etl/magento2-api-client": "^0.1.0",
"php-etl/magento2-api-client": "2.4.x-dev",
"psr/simple-cache": "^3.0",
"php-etl/mapping-contracts": "0.4.*"
},
Expand Down
102 changes: 79 additions & 23 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions phpstan.neon
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
parameters:
level: 7
treatPhpDocTypesAsCertain: false
Loading
Loading