Skip to content

Commit

Permalink
Updated pipeline-contracts package to add the step codes everywhere i…
Browse files Browse the repository at this point in the history
…t is necessary
  • Loading branch information
gplanchat committed Nov 13, 2023
1 parent 2e621c4 commit 6d710d0
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"extra": {
"branch-alias": {
"dev-main": "0.4.x-dev"
"dev-main": "0.5.x-dev"
}
}
}
4 changes: 3 additions & 1 deletion src/RejectedItemException.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@

namespace Kiboko\Contract\Pipeline;

final class RejectedItemException extends \RuntimeException {}
final class RejectedItemException extends \RuntimeException
{
}
1 change: 1 addition & 0 deletions src/RejectionInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public function initialize(): void;

/** @param non-empty-array<mixed>|object $rejection */
public function reject(StepCodeInterface $step, array|object $rejection, \Throwable $exception = null): void;

public function rejectWithReason(StepCodeInterface $step, object|array $rejection, string $reason, null|\Throwable $exception = null): void;

Check failure on line 14 in src/RejectionInterface.php

View workflow job for this annotation

GitHub Actions / phpstan

Method Kiboko\Contract\Pipeline\RejectionInterface::rejectWithReason() has parameter $rejection with no value type specified in iterable type array.

Check failure on line 14 in src/RejectionInterface.php

View workflow job for this annotation

GitHub Actions / phpstan

Method Kiboko\Contract\Pipeline\RejectionInterface::rejectWithReason() has parameter $rejection with no value type specified in iterable type array.

Check failure on line 14 in src/RejectionInterface.php

View workflow job for this annotation

GitHub Actions / phpstan

Method Kiboko\Contract\Pipeline\RejectionInterface::rejectWithReason() has parameter $rejection with no value type specified in iterable type array.

public function teardown(): void;
Expand Down
4 changes: 3 additions & 1 deletion src/RunnableInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@
use Kiboko\Contract\Satellite\RunnableInterface as SatelliteRunableInterface;

/** @deprecated Use \Kiboko\Contract\Job\RunnableInterface instead */
interface RunnableInterface extends SatelliteRunableInterface {}
interface RunnableInterface extends SatelliteRunableInterface
{
}
1 change: 1 addition & 0 deletions src/StepRejectionInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public function initialize(): void;

/** @param non-empty-array<mixed>|object $rejection */
public function reject(array|object $rejection, \Throwable $exception = null): void;

public function rejectWithReason(object|array $rejection, string $reason, null|\Throwable $exception = null): void;

Check failure on line 14 in src/StepRejectionInterface.php

View workflow job for this annotation

GitHub Actions / phpstan

Method Kiboko\Contract\Pipeline\StepRejectionInterface::rejectWithReason() has parameter $rejection with no value type specified in iterable type array.

Check failure on line 14 in src/StepRejectionInterface.php

View workflow job for this annotation

GitHub Actions / phpstan

Method Kiboko\Contract\Pipeline\StepRejectionInterface::rejectWithReason() has parameter $rejection with no value type specified in iterable type array.

Check failure on line 14 in src/StepRejectionInterface.php

View workflow job for this annotation

GitHub Actions / phpstan

Method Kiboko\Contract\Pipeline\StepRejectionInterface::rejectWithReason() has parameter $rejection with no value type specified in iterable type array.

public function teardown(): void;
Expand Down

0 comments on commit 6d710d0

Please sign in to comment.