Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward factories implemented by PSR-18 clients if any #266

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

nicolas-grekas
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

E.g. Symfony's PSR-18 client implements the relevant PSR-17 factories.
This is just a minor improvement.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was wondering why we don't do that in Psr17Factory instead, but we don't pass the ClientInterface to it so thats why...

it makes sense to do that, yes.

@dbu dbu merged commit ed16f52 into 1.x Apr 22, 2024
29 checks passed
@dbu dbu deleted the psr17-http-client branch April 22, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants