Bug fix replace operation with null values (#333)

* Bugfix replace operation with null values * Added change log
php-translation · Sep 6, 2019 · 584b8b9 · 584b8b9
1 parent ecf4909
commit 584b8b9
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/Catalogue/Operation/ReplaceOperation.php b/Catalogue/Operation/ReplaceOperation.php
@@ -45,15 +45,15 @@ protected function processDomain($domain)
 
         foreach ($this->source->all($domain) as $id => $message) {
             $messageDomain = $this->source->defines($id, $intlDomain) ? $intlDomain : $domain;
-            $this->messages[$domain]['all'][$id] = $message;
-            $this->result->add([$id => $message], $messageDomain);
 
             if (!$this->target->has($id, $domain)) {
                 // No merge required
+                $translation = $message;
                 $this->messages[$domain]['new'][$id] = $message;
                 $resultMeta = $this->getMetadata($this->source, $messageDomain, $id);
             } else {
                 // Merge required
+                $translation = $message ?? $this->target->get($id, $domain);
                 $resultMeta = null;
                 $sourceMeta = $this->getMetadata($this->source, $messageDomain, $id);
                 $targetMeta = $this->getMetadata($this->target, $this->target->defines($id, $intlDomain) ? $intlDomain : $domain, $id);
@@ -68,6 +68,9 @@ protected function processDomain($domain)
                 }
             }
 
+            $this->messages[$domain]['all'][$id] = $translation;
+            $this->result->add([$id => $translation], $messageDomain);
+
             if (!empty($resultMeta)) {
                 $this->result->setMetadata($id, $resultMeta, $messageDomain);
             }

diff --git a/Changelog.md b/Changelog.md
@@ -2,6 +2,12 @@
 
 The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.
 
+## 0.9.1
+
+### Fixed
+
+- Fixed issue with translations falsely marked as obsolete
+
 ## 0.9.0
 
 ### Added

diff --git a/Tests/Unit/Catalogue/Operation/ReplaceOperationTest.php b/Tests/Unit/Catalogue/Operation/ReplaceOperationTest.php
@@ -54,6 +54,19 @@ public function testGetResultFromSingleDomain()
         );
     }
 
+    public function testGetResultWithNullValues()
+    {
+        $this->assertEquals(
+            new MessageCatalogue('en', [
+                'messages' => ['a' => 'old_a', 'b' => 'old_b', 'c' => null],
+            ]),
+            $this->createOperation(
+                new MessageCatalogue('en', ['messages' => ['a' => null, 'c' => null]]),
+                new MessageCatalogue('en', ['messages' => ['a' => 'old_a', 'b' => 'old_b']])
+            )->getResult()
+        );
+    }
+
     public function testGetResultWithMetadata()
     {
         $leftCatalogue = new MessageCatalogue('en', ['messages' => ['a' => 'new_a', 'b' => 'new_b']]);