Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make $timeout arguments non-nullable #254

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Make $timeout arguments non-nullable #254

merged 2 commits into from
Aug 17, 2023

Conversation

TravisCarden
Copy link
Collaborator

$timeout arguments used to take null to disable timeout. This changes them to be-non-nullable and take zero (0) instead to impose no limit, in line with set_time_limit().

@TravisCarden TravisCarden added the bc break Includes API changes that may require updates in client code label Aug 17, 2023
@TravisCarden TravisCarden added this to the v2.0.0 milestone Aug 17, 2023
@TravisCarden TravisCarden merged commit 4b07d1f into php-tuf:develop Aug 17, 2023
8 checks passed
@TravisCarden TravisCarden deleted the feature/non-nullable-timeouts branch August 17, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bc break Includes API changes that may require updates in client code
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@TravisCarden