Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayObject::__construct Replace tag and implement → extend + CS #4416

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mmalferov
Copy link
Member

No description provided.

@Girgias Girgias merged commit 0aa6447 into php:master Jan 27, 2025
2 checks passed
@mmalferov mmalferov deleted the patch-6 branch January 27, 2025 22:34
@mmalferov
Copy link
Member Author

Maybe create a separate pull request that corrects the categorical requirement to extend the iterator class?

The class must extend the ArrayIterator class.

To:

The class must belong to or extend the ArrayIterator class.

<?php

$array = [];

// The third argument do not extends the ArrayIterator class, while "MUST"
$arrayObject = new ArrayObject($array, 0, 'ArrayIterator');```

@Girgias
Copy link
Member

Girgias commented Jan 30, 2025

I suppose

must be a subclass (or subtype) of ArrayIterator
would work better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants