Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly #68

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mrngm
Copy link
Contributor

@mrngm mrngm commented May 8, 2023

This prevents compile-time warnings about missing field initializers.

@mrngm mrngm changed the title ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly WIP: ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly May 8, 2023
@langemeijer
Copy link
Collaborator

Is this still WIP?

mrngm and others added 2 commits August 1, 2023 16:45
And include comments to refer to PHP's `main/php_streams.h` struct `php_stream_wrapper_ops`.
@mrngm mrngm changed the title WIP: ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly Aug 1, 2023
@mrngm
Copy link
Contributor Author

mrngm commented Aug 1, 2023

Apologies for not looking into this for a while. It still needed modifications in ssh2_sftp.c, which I've added just now. I've used the Github interface for updating this branch to the latest master commit, but if you rather have it rebased, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants