Skip to content

Commit

Permalink
Remove unused HAVE_PHPDBG (#14864)
Browse files Browse the repository at this point in the history
This is not defined on Windows and isn't used. Also phpdbg doesn't
install any headers to the public usage.
  • Loading branch information
petk authored Jul 7, 2024
1 parent 1bdf9aa commit 3d8bd8f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions UPGRADING.INTERNALS
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ PHP 8.4 INTERNALS UPGRADE NOTES
- Symbols PHP_FPM_SYSTEMD, PHP_FPM_USER, and PHP_FPM_GROUP removed.
- Symbol PTHREADS has been removed.
- Symbol HAVE_STRPTIME_DECL_FAILS has been removed (use HAVE_DECL_STRPTIME).
- Symbol HAVE_PHPDBG has been removed.
- Symbols PHP_HAVE_AVX512_SUPPORTS and PHP_HAVE_AVX512_VBMI_SUPPORTS are now
either defined to 1 or undefined.
- M4 macro PHP_DEFINE (atomic includes) removed (use AC_DEFINE and config.h).
Expand Down
1 change: 0 additions & 1 deletion sapi/phpdbg/config.m4
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ PHP_ARG_ENABLE([phpdbg-readline],

if test "$PHP_PHPDBG" != "no"; then
AC_HEADER_TIOCGWINSZ
AC_DEFINE(HAVE_PHPDBG, 1, [ ])

PHP_PHPDBG_CFLAGS="-DZEND_ENABLE_STATIC_TSRMLS_CACHE=1"
AS_VAR_IF([PHP_PHPDBG_DEBUG], [no],,
Expand Down

0 comments on commit 3d8bd8f

Please sign in to comment.