Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-17984: gd calls with array arguments. #17985

Closed
wants to merge 2 commits into from
Closed

Fix GH-17984: gd calls with array arguments. #17985

wants to merge 2 commits into from
+48 −4

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Mar 6, 2025

No description provided.

@devnexen devnexen marked this pull request as ready for review March 6, 2025 23:43
@devnexen devnexen requested a review from nielsdos March 6, 2025 23:43
@devnexen
Copy link
Member Author

devnexen commented Mar 6, 2025

@nielsdos I ve even tried imagettftext* locally, let me know if I missed something.

nielsdos
nielsdos reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, misses only the following though:

php-src/ext/gd/gd.c

Line 3420 in 5a3de04

if ((var = zend_hash_index_find(Z_ARRVAL_P(hash_matrix), (i))) != NULL && Z_TYPE_P(var) == IS_ARRAY) {
because of the IS_ARRAY type check, the rest should be fine

nielsdos
nielsdos approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@devnexen devnexen closed this in 07ceadf Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: gd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @nielsdos