Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix typo #459

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Docs: fix typo #459

merged 1 commit into from
Oct 30, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Oct 28, 2023

Came across this while testing a new sniff I'm working on 😁

@jrfnl
Copy link
Contributor Author

jrfnl commented Oct 28, 2023

Looks like your coding standards would prefer to remove the tag (which wasn't flagged before due to the typo). Shall I ?

Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag can be removed entirely, as the native return type already describes the type.

(which contained a typo, which is why it wasn't removed before)
@jrfnl jrfnl force-pushed the feature/docs-fix-typo branch from fd3346d to c17f78a Compare October 29, 2023 23:11
@jrfnl
Copy link
Contributor Author

jrfnl commented Oct 29, 2023

@jaapio Done ;-)

@jaapio jaapio merged commit e6cca3e into phpDocumentor:5.x Oct 30, 2023
36 checks passed
@jaapio
Copy link
Member

jaapio commented Oct 30, 2023

Thanks!

@jrfnl jrfnl deleted the feature/docs-fix-typo branch October 30, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants