Resource/Object specific data key support #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to support resource/object level data keys as well as request level.
As example:
The recently added
AssignedFulfillmentOrder
resource. It returns results with thefulfillment_orders
key, which does not match the resource key.While a data key can be manually passed to
get()
, it feels messy for a resource which always requires a custom data key.Setting the protected
$dataKey
property in a resource object will cause the specified key to be used with results (unless a key is provided manually).(Therefore, this PR "fixes" the response payload from
AssignedFulfillmentOrder
)