Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavenized #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Mavenized #1

wants to merge 3 commits into from

Conversation

nitramek
Copy link

Hi, I use Java quite a bit and thought it might be useful to mavenize the project. The building process is simple you can just build it by running mvn clean install.
I like runnable jars without dependencies so I configured it that way. Also I removed (hopefully) unecessary classes and added them as dependencies.
Tested it this build and it works.

If you have any questions or points to make just let me know. I have tried the program it works but I right now I dont have much time to spare so I wont be testing it too much.

Thanks for your project!

@nitramek nitramek closed this Mar 28, 2018
@nitramek nitramek deleted the mavenized branch March 28, 2018 17:58
@nitramek nitramek restored the mavenized branch March 28, 2018 17:58
@nitramek nitramek reopened this Mar 28, 2018
@nitramek
Copy link
Author

Sorry for confusion, I made changes in the commit author so it looked weird but it is the same thing.

@phr00t
Copy link
Owner

phr00t commented Mar 28, 2018

Thank you for the contribution & interest!

I don't use maven myself & I'm not setup to manage the project with maven in mind, so I don't want to restructure my master branch like this. I know lots of people do use maven & you are in a much better position to maintain a mavenized branch you've forked already.

If I update this repository, you can merge the changes into your mavenized branch without much hassle, right?

@nitramek
Copy link
Author

nitramek commented Mar 28, 2018

I see, I can do that but I am not sure those probably wont even be merges, cause the structure is different. I would have to do it manually. EDIT: or I dont know how else.

I can check once in a while to update the branch just but your commits will be gone on that branch.

But if you want to use maven this project should "work" if you just install the latest maven version and use the commands I wrote in README.md

IDEs also support maven so you can import the project by doing that as well.

@yac
Copy link

yac commented Jul 18, 2018

Hello. Please note that out of two forks of this repo existing at the time of writting, both add a way to build this easily as a first patch. If you want people contribute to this project and improve it together instead of forking, providing a way to easily build and test changes (contributions) is essential.

I personally prefer the gradle patch that restructures your repo to only contain the AutoStepper sources and uses nice gradlew wrapper to get everything else.

I applied this cool patch (only small merge conflicts with master) and ran gradlew without any special setup and it just worked \o/ It contains no ugly XML and isn't very intrusive.

Look how nice the structure looks with this improvement (dist isn't and shouldn't be part of the source repo):

├── README.md
├── build.gradle
├── gradlew
├── gradlew.bat
└── src
    └── main
        └── java
            └── com
                └── phr00t
                    └── autostepper
                        ├── AutoStepper.java
                        ├── GoogleImageSearch.java
                        ├── SMGenerator.java
                        └── StepGenerator.java

Please consider adopting this patch and if you don't like it, provide a way to compile this with a single command.

madewithlinux pushed a commit to madewithlinux/AutoStepper that referenced this pull request Jul 9, 2023
* Convert to gradle project

* Update gradle wrapper to 4.8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants