Adding units mm of H2O, inches of H2O (water column) and inches of Hg #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- need help with translation and file formatting (Right Justified)
- Attempted with other units as sample
Needs translation assistance - Attempted with other units as sample
need translation assistance
- Attempted with other units as sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For work in HVAC and process control, I use inches and mm of water column often, and wanted to round out this application. Inches of mercury is a simple translation, I figured it could be added just in case it's needed.
Inches H2O based from Wikipedia (https://en.wikipedia.org/wiki/Inch_of_water).
mm H2O based on inches H2O divided by 25.4 or https://en.wikipedia.org/wiki/Centimetre_of_water
inHg based from mmHg but multiplied by 25.4 per Wikipedia (https://en.wikipedia.org/wiki/Inch)
I made attempts with values-fa/strings.xml, /values-hu/strings.xml, and /values-ru/strings.xml. These likely need translation correction for the terms.