Update po files, containing translation messages #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-rem
changed the title
Base automatically changed from
WIP/[email protected]/fix_replacements
to
main
December 12, 2024 11:09
po files contain translation messages. Sphinx generates comment lines, prefixed with '#:' that show where the translated paragraph belongs to. The bsp manuals are build out of multiple .rsti files, once a line in an .rsti file changes, all subsequent lines of the generated .rst file will change. This creates huge diffs, that do not offer real advantages. The comment lines are not used by the tooling and can be removed. This commit also introduces a script that performs this cleanup. This script is invoked each time the internationalization files are updated: sphinx -e py3-intl Signed-off-by: Jonas Remmert <[email protected]>
Signed-off-by: Jonas Remmert <[email protected]>
jonas-rem
force-pushed
the
WIP/[email protected]/update_po_files
branch
from
e0ace6b to
017a223
Compare
|
@annie-pixel updated this PR after merging #263. Can you review it? |
annie-pixel
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #263@annie-pixel I removed the comment lines in the po files, as those cause very large diffs at minimal changes of the content. Can you check if you observe any disadvantages when using the po files with poedit.