Skip to content

Commit

Permalink
ci: fix commit comments, pr title validation and autofix (tailcallhq#…
Browse files Browse the repository at this point in the history
…1092)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
  • Loading branch information
meskill and autofix-ci[bot] authored Feb 2, 2024
1 parent 0748dc2 commit 4edd050
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 5 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
paths-ignore: ["docs/**", "**.md"]
types: [opened, reopened, synchronize, labeled]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
macro_benchmark:
name: Macro Benchmarks
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ on:
permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
# TODO: cancel in progress is not ok for a release since it can be cancelled in a middle of updates
# and we can end up with partial release.
# but for pull-requests cancelling previously running jobs could be beneficial
# cancel-in-progress: true

jobs:
check_if_build:
name: Check if Build
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/comment-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:
name: Comment on commit
runs-on: ubuntu-latest
if: >
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.conclusion == 'success'
steps:
- name: Download artifact with body message
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ on:
permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
lint:
name: Run Formatter and Lint Check
Expand All @@ -26,14 +30,12 @@ jobs:
node-version: "20.11.0"
- name: Install Prettier
run: npm install --global prettier
- uses: actions/checkout@v4
- name: Install Nightly Toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: nightly
components: rustfmt, clippy
- uses: actions/checkout@v4
with:
ref: ${{ (env.LINT_MODE == 'fix' && github.event.pull_request.head.sha) || '' }}
- name: Run Lint Script
run: ./lint.sh --mode=$LINT_MODE
- name: Commit and push if changed
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-convention.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
# pull_request_target is ok until we do not checkout and build external code
# TODO: maybe it is not required after all https://github.com/amannn/action-semantic-pull-request/issues/219
pull_request_target:
types: [opened, edited]
types: [opened, reopened, synchronize, edited]

permissions:
pull-requests: read
Expand Down

0 comments on commit 4edd050

Please sign in to comment.