Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] getDenormalisedWeight #26

Closed
3 of 6 tasks
MickdeGraaf opened this issue May 21, 2020 · 3 comments
Closed
3 of 6 tasks

[Feature] getDenormalisedWeight #26

MickdeGraaf opened this issue May 21, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@MickdeGraaf
Copy link
Member

MickdeGraaf commented May 21, 2020 •
edited by travisdmathis
Loading

User Story

  • As an <audience/user>: Dev interacting with the smart contract.
  • I want to <action/task>: Be able to get the denormalised weight of a specific token in the underlying balancer pool.
  • so that <outcome/goal/benefit>: So I don't have to call it directly.

Type

  • Enhancement
  • Maintenance
  • Refactor

Description

Calls the exact same function on the underlying pool contract.

Definition of Done

  • Implement getDenormalizedWeight(address token)
  • Sufficient test coverage in unit tests
  • Tested in mainnet test

Attach files or screenshots if it's helpful for this issue.

Reference implementation: https://github.com/balancer-labs/smart-pools/blob/master/crp/contracts/ConfigurableRightsPool.sol#L112
@dmvt
Copy link
Contributor

dmvt commented Jun 1, 2020

https://forum.piedao.org/t/bounty-program-votes/118/2
PieDAO governance has voted to approve this issue for a bounty:
Approved Scope: 4 - 8 hours (1397.6 - 2795.2 $DOUGH)
Contributor: @travisdmathis

@dmvt dmvt assigned dmvt and unassigned dmvt Jun 1, 2020
@travisdmathis travisdmathis self-assigned this Jun 1, 2020
@travisdmathis travisdmathis added the enhancement New feature or request label Jun 1, 2020
@travisdmathis travisdmathis mentioned this issue Jun 2, 2020
Merged
3 tasks
dmvt pushed a commit that referenced this issue Jun 8, 2020
@travisdmathis
Feature/get denormalized weight #26 (#35)
071fcbd 
* rebase

* fix conflicts

* moves mainnet test
@dmvt dmvt reopened this Jun 18, 2020
@dmvt
Copy link
Contributor

dmvt commented Jun 18, 2020

Leaving this in done until we work out the disbursement

@travisdmathis travisdmathis reopened this Jun 24, 2020
@MickdeGraaf MickdeGraaf mentioned this issue Jul 28, 2020
Merged
3 tasks
@MickdeGraaf
Copy link
Member Author

Implemented in #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmvt @MickdeGraaf @travisdmathis