Feature/get denormalized weight #26 #35
Conversation
There was a problem hiding this comment.
I agree that we should better format the code and apply linting more properly.
However I'm not fully agreeing with formatting which is applied now and also think this PR should not be the place for changing the formatting of 44 files.
@dmvt Any thoughts?
|
Feels like a separate PR business. |
@MickdeGraaf The formatting applied is coming from your prettier config in the project repo, it is not something I created. This was formatted using that config. It has just never been run against the code base until now I guess. |
travisdmathis
force-pushed
the
feature/get-denormalized-weight-#26
branch
from
8976343 to
da3c2d8
Compare
There was a problem hiding this comment.
LGTM
@dmvt I think we should merge development into master, tag a release and then merge this into development.
@travisdmathis You can submit a token request for this bounty to the DAO as it's finished.
|
@dmvt requesting 1397.6 DOUGH for 4HRS total. |
|
@MickdeGraaf It's not a release yet because we're not deploying it. The release branch and ultimate stage would be between development and master. Congrats on the first bounty @travisdmathis!! |
|
Good job @travisdmathis 🔥 |
Description
Checklist
Testing
I have written tests to satisfy the additions to the pBasicSmartPool contract.
Refers/Fixes
Refers #26
Total Hours: 4