815 reference checker should handled the input files the same for the check dir than the check project #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the impression that a test is missing showing that if we have We treat ABC and not ACBC |
Ducasse
reviewed
Sep 5, 2024
| @@ -161,7 +161,7 @@ MicFileCollectorTest >> testOnlyGoUpInFoldersStartingFromAnotherRoot [ | |||
|
|
|||
| { #category : 'tests' } | |||
| MicFileCollectorTest >> testUnreferencedFileAreNotHandled [ | |||
| "This test verifies that the collector only collects files that are referenced from a root and not all the files in a folder." | |||
| "This test verifies that the collector only collects files that are referenced from a root and not all the files in a folder. " | |||
There was a problem hiding this comment.
Remove tab in the comment please
Ducasse
reviewed
Sep 5, 2024
| { #category : 'visiting' } | ||
| MicFileCollector >> add: aFile [ | ||
|
|
||
| worklist add: aFile . |
Ducasse
reviewed
Sep 5, 2024
| { #category : 'visiting' } | ||
| MicFileCollector >> workList [ | ||
|
|
||
| ^ worklist . |
Ducasse
reviewed
Sep 5, 2024
|
|
||
| collector | ||
| rootDirectory: FileSystem memory ; | ||
| visit: collector workList first . |
Ducasse
reviewed
Sep 5, 2024
| @@ -37,6 +37,7 @@ MicResult class >> headerString [ | |||
|
|
|||
| { #category : 'accessing' } | |||
| MicResult >> explanation [ | |||
| "just test " | |||
Ducasse
reviewed
Sep 5, 2024
|
|
||
| collector | ||
| rootDirectory: FileSystem memory ; | ||
| visit: collector workList first . |
There was a problem hiding this comment.
I do not get why we only start the first worklist and why it is not removed from the worklist and why
we do not handled the next ones?
Ducasse
reviewed
Sep 5, 2024
| @@ -794,8 +792,8 @@ MicReferenceCheckerTest >> testReportingUnknownAnchorDir [ | |||
| file2 ensureCreateFile. | |||
|
|
|||
| visitor := MicReferenceChecker new. | |||
|
|
|||
| self deny: (visitor checkDirectory: dir). | |||
| visitor checkDirectory: dir . | |||
Ducasse
reviewed
Sep 5, 2024
| @@ -342,6 +353,18 @@ MicFileTest >> section4InputsParentSection3 [ | |||
| ' ] | |||
| ] | |||
|
|
|||
| { #category : 'helpers - only inputfiles' } | |||
| MicFileTest >> section4InputsParentSection3withUknownAnchors [ | |||
There was a problem hiding this comment.
I do not see where this is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix checkDirectory