run tests with python 3.12 #1317
Conversation
|
blocked by aio-libs/aiohttp#7639 |
geier
force-pushed
the
chore/run_python_3.12
branch
3 times, most recently
from
d5c7d04
to
c56675c
Compare
| pytz20187: pytz==2018.7 | ||
| pytz_latest: pytz |
There was a problem hiding this comment.
These should remain in deps =:
| pytz20187: pytz==2018.7 | |
| pytz_latest: pytz | |
| deps = | |
| pytz20187: pytz==2018.7 | |
| pytz_latest: pytz |
| @@ -15,15 +15,10 @@ passenv = | |||
| TRAVIS_JOB_NUMBER | |||
| TRAVIS_PULL_REQUEST | |||
| TRAVIS_REPO_SLUG | |||
| deps = | |||
| pytest | |||
There was a problem hiding this comment.
pytest is missing from project.optional-dependencies.test. This is why CI is failing.
There was a problem hiding this comment.
Thanks. It looks like we still need to define all dependencies in tox.ini or make it run pip install independently. Not sure, which way is worse. For now I optioned for using commands_pre to run pip install .[test].
There was a problem hiding this comment.
Here you're overriding dependencies, so they need to be in the deps = array (e.g.: these two are not extras).
Fixing this tests work.
| freezegun | ||
| !py36: vdirsyncer | ||
| py36: vdirsyncer==0.16.8 | ||
| python-dateutil |
There was a problem hiding this comment.
This one is also missing, but is not required because it is a non-test dependency already.
There was a problem hiding this comment.
(nothing to do on this item, just FYI)
geier
force-pushed
the
chore/run_python_3.12
branch
from
955a901
to
fc5ba54
Compare
No description provided.