metasync: use None as no-value and delete missing values on syncing #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change the interface of Storage.get_meta() and .set_meta() to use '' as the empty value and None as missing value. - When a property is missing (e.g calendar-color was removed) in the filesystem storage delete the 'color' file, and in the WebDAV storage issue propertyupdate/remove call. - remove the property from [status]/[pair]/[collection].metadata I have adjusted, but not run the test suite. On the other side I tested on real system: source is CalDAV - destination is filesystem; and source is CalDAV, destination is CalDAV (another account)
|
It seems xandikos does not support deleting the property, I've reported this in jelmer/xandikos#137. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #871 rebased onto the current
master.Closes #871