Skip to content

Commit

Permalink
fully remove PINECONE_ENVIRONMENT from github workflows and the env v…
Browse files Browse the repository at this point in the history
…ariable validator
  • Loading branch information
austin-denoble committed Dec 29, 2023
1 parent b005a8b commit 6420237
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 12 deletions.
1 change: 0 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
PINECONE_API_KEY=
PINECONE_ENVIRONMENT=
PINECONE_INDEX=semantic-search
4 changes: 0 additions & 4 deletions .github/actions/integrationTests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ inputs:
pinecone_api_key:
description: "API key"
required: true
pinecone_environment:
description: "Environment/region to target"
required: true
runs:
using: "composite"
steps:
Expand All @@ -15,7 +12,6 @@ runs:
env:
CI: true
PINECONE_API_KEY: ${{ inputs.pinecone_api_key }}
PINECONE_ENVIRONMENT: ${{ inputs.pinecone_environment }}
PINECONE_INDEX: "semantic-search-testing"
run: npm run test
- name: "Report Coverage"
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/regularCheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ on:
secrets:
PINECONE_API_KEY:
required: true
PINECONE_ENVIRONMENT:
required: true
jobs:
run-integration-tests:
name: Integration tests
Expand All @@ -28,4 +26,3 @@ jobs:
uses: ./.github/actions/integrationTests
with:
PINECONE_API_KEY: ${{ secrets.PINECONE_API_KEY }}
PINECONE_ENVIRONMENT: ${{ secrets.PINECONE_ENVIRONMENT }}
3 changes: 0 additions & 3 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ on:
secrets:
PINECONE_API_KEY:
required: true
PINECONE_ENVIRONMENT:
required: true

jobs:
basic-hygiene:
Expand Down Expand Up @@ -49,4 +47,3 @@ jobs:
uses: ./.github/actions/integrationTests
with:
PINECONE_API_KEY: ${{ secrets.PINECONE_API_KEY }}
PINECONE_ENVIRONMENT: ${{ secrets.PINECONE_ENVIRONMENT }}
1 change: 0 additions & 1 deletion src/utils/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ function getEnv(key: string): string {

const validateEnvironmentVariables = () => {
getEnv("PINECONE_API_KEY");
getEnv("PINECONE_ENVIRONMENT");
getEnv("PINECONE_INDEX");
};

Expand Down

0 comments on commit 6420237

Please sign in to comment.