Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

master: add operate-source show #838

Merged
merged 11 commits into from
Jul 31, 2020
Merged

master: add operate-source show #838

merged 11 commits into from
Jul 31, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Jul 28, 2020 •
edited
Loading

What problem does this PR solve?

fix #832

What is changed and how it works?

operate-source show will output all source with their bounded worker (maybe empty)

Check List

Tests

  • Integration test

Code changes

  • Has (user) interface methods change

Side effects

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@lance6716 lance6716 added needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/bug-fix Bug fix labels Jul 28, 2020
@lance6716 lance6716 added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jul 29, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #838 into master will decrease coverage by 1.0953%.
The diff coverage is 41.6767%.

@@               Coverage Diff                @@
##             master       #838        +/-   ##
================================================
- Coverage   57.0981%   56.0028%   -1.0954%     
================================================
  Files           205        212         +7     
  Lines         21104      22231      +1127     
================================================
+ Hits          12050      12450       +400     
- Misses         7890       8552       +662     
- Partials       1164       1229        +65

csuzhangxc
csuzhangxc reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

GMHDBJD
GMHDBJD previously approved these changes Jul 31, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 31, 2020
csuzhangxc
csuzhangxc previously approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 31, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 31, 2020
@lance6716 lance6716 merged commit 4cdc36b into pingcap:master Jul 31, 2020
@lance6716 lance6716 deleted the source-show branch July 31, 2020 04:16
@ti-srebot
Copy link

cherry pick to release-1.0 failed

@lance6716 lance6716 removed the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Jul 31, 2020
@lance6716 lance6716 mentioned this pull request Aug 13, 2020
Merged
6 tasks
@csuzhangxc
Copy link
Member

docs PR pingcap/docs-dm#219

@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Aug 14, 2020
@csuzhangxc csuzhangxc removed the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@GMHDBJD GMHDBJD GMHDBJD left review comments

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.

Add a way to check the sources
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD