Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Aolin <[email protected]>
  • Loading branch information
csuzhangxc and Oreoxmt authored May 27, 2024
1 parent 2387c43 commit 77ef2a3
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions en/releases/release-1.6.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ TiDB Operator version: 1.6.0

## New features

- Support setting `maxSkew`, `minDomains` and `nodeAffinityPolicy` in `topologySpreadConstraints` for components of a TidbCluster ([#5617](https://github.com/pingcap/tidb-operator/pull/5617), [@csuzhangxc](https://github.com/csuzhangxc))
- Support set extra command line arguments for TiDB component ([#5624](https://github.com/pingcap/tidb-operator/pull/5624), [@csuzhangxc](https://github.com/csuzhangxc))
- Support setting `maxSkew`, `minDomains`, and `nodeAffinityPolicy` in `topologySpreadConstraints` for components of a TiDB cluster ([#5617](https://github.com/pingcap/tidb-operator/pull/5617), [@csuzhangxc](https://github.com/csuzhangxc))
- Support setting additional command-line arguments for TiDB components ([#5624](https://github.com/pingcap/tidb-operator/pull/5624), [@csuzhangxc](https://github.com/csuzhangxc))
- Support setting `nodeSelector` for the TidbInitializer component ([#5594](https://github.com/pingcap/tidb-operator/pull/5594), [@csuzhangxc](https://github.com/csuzhangxc))

## Improvements

- Support automatically set location labels for TiProxy ([#5649](https://github.com/pingcap/tidb-operator/pull/5649), [@djshow832](https://github.com/djshow832))
- Support retrying to evict leader when rolling upgrade TiKV ([#5613](https://github.com/pingcap/tidb-operator/pull/5613), [@csuzhangxc](https://github.com/csuzhangxc))
- Support setting `advertise-addr` command line argument for TiProxy component ([#5608](https://github.com/pingcap/tidb-operator/pull/5608), [@djshow832](https://github.com/djshow832))
- Support automatically setting location labels for TiProxy ([#5649](https://github.com/pingcap/tidb-operator/pull/5649), [@djshow832](https://github.com/djshow832))
- Support retrying leader eviction during TiKV rolling restart ([#5613](https://github.com/pingcap/tidb-operator/pull/5613), [@csuzhangxc](https://github.com/csuzhangxc))
- Support setting the `advertise-addr` command-line argument for the TiProxy component ([#5608](https://github.com/pingcap/tidb-operator/pull/5608), [@djshow832](https://github.com/djshow832))

## Bug fixes

Expand Down
6 changes: 3 additions & 3 deletions en/whats-new-in-v1.6.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ TiDB Operator 1.6 introduces the following key features, which helps you manage

## Usability

- Support automatically set location labels for TiProxy.
- Support setting `maxSkew`, `minDomains` and `nodeAffinityPolicy` in `topologySpreadConstraints` for components of a TidbCluster.
- Support automatically setting location labels for TiProxy.
- Support setting `maxSkew`, `minDomains`, and `nodeAffinityPolicy` in `topologySpreadConstraints` for components of a TiDB cluster.
- Support setting `startupProbe` for TiDB components.
- Support set extra command line arguments for TiDB component.
- Support setting additional command-line arguments for TiDB components.
- Support setting `livenessProbe` and `readinessProbe` for the Discovery component.
- Support setting `nodeSelector` for the TidbInitializer component.
- Support for TiFlash to directly mount ConfigMap without relying on an InitContainer to process configuration files.
2 changes: 1 addition & 1 deletion zh/releases/release-1.6.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ TiDB Operator 版本:1.6.0

- 支持自动为 TiProxy 设置 location labels ([#5649](https://github.com/pingcap/tidb-operator/pull/5649), [@djshow832](https://github.com/djshow832))
- 支持在滚动重启 TiKV 时,对 evict leader 执行重试 ([#5613](https://github.com/pingcap/tidb-operator/pull/5613), [@csuzhangxc](https://github.com/csuzhangxc))
- TiProxy 组件设置 `advertise-addr` 参数 ([#5608](https://github.com/pingcap/tidb-operator/pull/5608), [@djshow832](https://github.com/djshow832))
- 支持为 TiProxy 组件设置 `advertise-addr` 参数 ([#5608](https://github.com/pingcap/tidb-operator/pull/5608), [@djshow832](https://github.com/djshow832))

## Bug 修复

Expand Down
2 changes: 1 addition & 1 deletion zh/whats-new-in-v1.6.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ TiDB Operator v1.6 引入了以下关键特性,从扩展性、易用性等方

## 兼容性改动

- 升级 Kubernetes 依赖库至 v1.28 版本,建议不再部署 tidb-schedule 组件。
- 升级 Kubernetes 依赖库至 v1.28 版本,建议不再部署 tidb-scheduler 组件。
- 通过 Helm Chart 部署时支持设置 tidb-controller-manager 用于 leader 选举的 lock resource,默认值为 `.Values.controllerManager.leaderResourceLock: leases`。当从 v1.6 之前的版本升级到 v1.6.0-beta.1 及之后的版本时,推荐先设置 `.Values.controllerManager.leaderResourceLock: endpointsleases` 并待新的 tidb-controller-manager 正常运行后再设置为 `.Values.controllerManager.leaderResourceLock: leases` 以更新部署。

## 扩展性
Expand Down

0 comments on commit 77ef2a3

Please sign in to comment.