Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mountOptions to separate options #2466

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

hongshaoyang
Copy link
Contributor

@hongshaoyang hongshaoyang commented Nov 8, 2023

First-time contributors' checklist

What is changed, added, or deleted? (Required)

  • Update storageClass mountOptions to 2 separate options, instead of separated by commas.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2023
@ti-chi-bot ti-chi-bot bot requested review from ran-huang and yiduoyunQ November 8, 2023 10:08
Copy link

ti-chi-bot bot commented Nov 8, 2023

@hongshaoyang: GitHub didn't allow me to request PR reviews from the following users: KanShiori.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @KanShiori

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested a review from csuzhangxc November 8, 2023 10:12
@ti-chi-bot ti-chi-bot bot assigned hongshaoyang and unassigned hongshaoyang Nov 8, 2023
@ran-huang ran-huang added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 13, 2023
@ran-huang ran-huang added the needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2023
Copy link

ti-chi-bot bot commented Nov 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-13 07:03:49.381761828 +0000 UTC m=+4059826.968871974: ☑️ agreed by ran-huang.

Copy link

ti-chi-bot bot commented Jan 16, 2024

@yiduoyunQ: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiduoyunQ
Copy link
Contributor

LGTM

@ran-huang
Copy link
Contributor

/approve

@ran-huang ran-huang added the lgtm label Jan 19, 2024
Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 18a60cb into pingcap:master Jan 19, 2024
12 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2494.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants