Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh, en: remove tkctl #2470

Merged
merged 1 commit into from
Nov 28, 2023
Merged

zh, en: remove tkctl #2470

merged 1 commit into from
Nov 28, 2023

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Nov 27, 2023

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Remove tkctl as "PingCAP 从 v1.1.x 开始不再维护 tkctl".

ref pingcap/tidb-operator#5420 and PingCAP-QE/ci#2635

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 27, 2023
@csuzhangxc csuzhangxc requested a review from ran-huang November 27, 2023 09:16
@csuzhangxc csuzhangxc changed the title zh, cn: remove tkctl zh, en: remove tkctl Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-28 05:12:35.483561071 +0000 UTC m=+899584.148787251: ☑️ agreed by ran-huang.

@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed missing-translation-status This PR does not have translation status info. labels Nov 28, 2023
@ran-huang ran-huang added the lgtm label Nov 28, 2023
@ran-huang
Copy link
Contributor

/approve

Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit e5d1f20 into pingcap:master Nov 28, 2023
11 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2471.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2023
6 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
@csuzhangxc csuzhangxc deleted the remove-tkctl branch November 28, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants