Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale-a-tidb-cluster: fix pd micro service indent #2526

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Mar 25, 2024

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp requested a review from qiancai March 25, 2024 07:52
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2024
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-25 08:05:24.685521266 +0000 UTC m=+1882351.707767640: ☑️ agreed by qiancai.

@qiancai qiancai added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 25, 2024
@qiancai
Copy link
Collaborator

qiancai commented Mar 25, 2024

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@qiancai: once the present PR merges, I will cherry-pick it on top of release-1.6 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Collaborator

qiancai commented Mar 25, 2024

/approve

@qiancai qiancai added the lgtm label Mar 25, 2024
Copy link

ti-chi-bot bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit bebf614 into pingcap:master Mar 25, 2024
13 checks passed
@ti-chi-bot
Copy link
Member

@qiancai: new pull request created to branch release-1.6: #2528.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants