Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM: Revise wrong syntax for command example on get into the pod in eng doc (#2587) #2592

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2587

#2586 Example syntax error in eng doc.

What is changed, added, or deleted? (Required)

Add a hyphen on kubectl command: from kubectl exec -it - to kubectl exec -it --
because - is not valid syntax, and will throw an error message. Detail inside the #2586

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

NA

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-1.6 labels Jul 9, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 9, 2024

/approve

Copy link

ti-chi-bot bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1bf1763 into pingcap:release-1.6 Jul 9, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-1.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants