Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add resource management topic and split docs #20010

Merged
merged 27 commits into from
Feb 7, 2025

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jan 15, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 15, 2025
Signed-off-by: nolouch <[email protected]>
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Jan 15, 2025
@hfxsd hfxsd self-assigned this Jan 15, 2025
@hfxsd hfxsd self-requested a review January 15, 2025 14:15
basic-features.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

Signed-off-by: nolouch <[email protected]>
@nolouch
Copy link
Member Author

nolouch commented Feb 5, 2025

ptal @hfxsd

TOC.md Outdated Show resolved Hide resolved
faq/sql-faq.md Outdated Show resolved Hide resolved
functions-and-operators/tidb-functions.md Outdated Show resolved Hide resolved
information-schema/information-schema-resource-groups.md Outdated Show resolved Hide resolved
tidb-resource-control-background-tasks.md Outdated Show resolved Hide resolved
tidb-resource-control-ru-groups.md Outdated Show resolved Hide resolved
tidb-resource-control-runaway-queries.md Outdated Show resolved Hide resolved
tiflash/tiflash-pipeline-model.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
system-variable-reference.md Outdated Show resolved Hide resolved
system-variable-reference.md Outdated Show resolved Hide resolved
TOC-tidb-cloud.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from qiancai February 7, 2025 08:43
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@@ -1895,7 +1895,7 @@ Referenced in:
- [SET RESOURCE GROUP](/sql-statements/sql-statement-set-resource-group.md)
- [System Variables](/system-variables.md#tidb_enable_resource_control-new-in-v660)
- [TiKV Configuration File](/tikv-configuration-file.md)
- [Use Resource Control to Achieve Resource Isolation](/tidb-resource-control.md)
- [Use Resource Control to Achieve Resource Group Limitation](/tidb-resource-control-ru-groups.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Use Resource Control to Achieve Resource Group Limitation](/tidb-resource-control-ru-groups.md)
- [Use Resource Control to Achieve Resource Group Limitation and Flow Control](/tidb-resource-control-ru-groups.md)

tidb-resource-control-runaway-queries.md Show resolved Hide resolved
tidb-resource-control-runaway-queries.md Outdated Show resolved Hide resolved
tidb-resource-control-runaway-queries.md Outdated Show resolved Hide resolved
tidb-resource-control-background-tasks.md Outdated Show resolved Hide resolved
tidb-resource-control-background-tasks.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 7, 2025
system-variable-reference.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2025
Copy link

ti-chi-bot bot commented Feb 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-07 09:22:14.291687034 +0000 UTC m=+2776.687909096: ☑️ agreed by qiancai.
  • 2025-02-07 09:46:10.196985731 +0000 UTC m=+4212.593207787: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Feb 7, 2025

/approve

Copy link

ti-chi-bot bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 7, 2025
@ti-chi-bot ti-chi-bot bot merged commit 0fc1f77 into pingcap:master Feb 7, 2025
8 of 9 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 7, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants