Added a new PrepareBackup RPC for snapshot backup
#1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connor1996
reviewed
Nov 3, 2023
| @@ -15,6 +15,30 @@ option (rustproto.lite_runtime_all) = true; | |||
|
|
|||
| option java_package = "org.tikv.kvproto"; | |||
|
|
|||
| enum PrepareSnapshotBackupRequestType { | |||
| UpdateLease = 0; | |||
There was a problem hiding this comment.
Updating the TTL, I will add some comments then.
overvenus
reviewed
Nov 3, 2023
| WaitApply = 1; | ||
| } | ||
|
|
||
| message PrepareSnapshotBackupRequest { |
There was a problem hiding this comment.
Please add some comments about the message and fields.
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
YuJuncen
force-pushed
the
advanced-prepare
branch
from
1f1b185 to
d6c4847
Compare
…nced-prepare Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Connor1996
reviewed
Jan 3, 2024
proto/brpb.proto
Outdated
| @@ -15,6 +15,47 @@ option (rustproto.lite_runtime_all) = true; | |||
|
|
|||
| option java_package = "org.tikv.kvproto"; | |||
|
|
|||
| enum PrepareSnapshotBackupRequestType { | |||
| // Update the lease of suspending new ingest / admin commands to be proposed. | |||
There was a problem hiding this comment.
Please describe what's the lease used for
overvenus
approved these changes
Jan 9, 2024
Signed-off-by: hillium <[email protected]>
YuJuncen
added a commit
to YuJuncen/kvproto
that referenced
this pull request
Jan 11, 2024
* added basic proto Signed-off-by: hillium <[email protected]> * finish Signed-off-by: hillium <[email protected]> * update new version of advanced prepare Signed-off-by: hillium <[email protected]> * added some comments and a new request type Signed-off-by: hillium <[email protected]> * added more comments Signed-off-by: hillium <[email protected]> * make go Signed-off-by: hillium <[email protected]> * address comments Signed-off-by: hillium <[email protected]> --------- Signed-off-by: hillium <[email protected]>
YuJuncen
added a commit
that referenced
this pull request
Jan 12, 2024
* added basic proto * finish * update new version of advanced prepare * added some comments and a new request type * added more comments * make go * address comments --------- Signed-off-by: hillium <[email protected]>
YuJuncen
added a commit
to YuJuncen/kvproto
that referenced
this pull request
Feb 20, 2024
* added basic proto Signed-off-by: hillium <[email protected]> * finish Signed-off-by: hillium <[email protected]> * update new version of advanced prepare Signed-off-by: hillium <[email protected]> * added some comments and a new request type Signed-off-by: hillium <[email protected]> * added more comments Signed-off-by: hillium <[email protected]> * make go Signed-off-by: hillium <[email protected]> * address comments Signed-off-by: hillium <[email protected]> --------- Signed-off-by: hillium <[email protected]>
YuJuncen
added a commit
that referenced
this pull request
Feb 20, 2024
) * Added a new `PrepareBackup` RPC for snapshot backup (#1204) * added basic proto Signed-off-by: hillium <[email protected]> * finish Signed-off-by: hillium <[email protected]> * update new version of advanced prepare Signed-off-by: hillium <[email protected]> * added some comments and a new request type Signed-off-by: hillium <[email protected]> * added more comments Signed-off-by: hillium <[email protected]> * make go Signed-off-by: hillium <[email protected]> * address comments Signed-off-by: hillium <[email protected]> --------- Signed-off-by: hillium <[email protected]> * try trigger github action Signed-off-by: hillium <[email protected]> --------- Signed-off-by: hillium <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q & A
Some questions you may like to ask:
Q: Is it possible to split this into two RPCs?
Surely we can split this into two RPCs: one for ready and one for wait applies.
This will allow us to reuse some gRPC's infras to control connections, and easier to be understood the behavior.
But I don't want to do this because: