restore: support skip some keys due before/after certain timestamp #1283
Conversation
3pointer
changed the title
| @@ -140,7 +140,12 @@ message SSTMeta { | |||
| message RewriteRule { | |||
| bytes old_key_prefix = 1; | |||
| bytes new_key_prefix = 2; | |||
| // (Optional) Rewrite all keys in the range to use this timestamp. | |||
There was a problem hiding this comment.
A suggestion, since all of these are optional, can we put them into a new message like RewriteSkipRule or something. feels like we can easily check on its optional state in the code and could be cleaner.
There was a problem hiding this comment.
Need to consider compatibility if we move new_timestamp to new place.
I would like to keep it simple. until there need more field in future.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, joccau, tangenta, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
For some special download, we need to skip rewrite some keys because the timestamp is not in a target range.
This PR tried to add more rule about the restore phase.
When set the
ignore_after_timestampthe sst will trigger the rewrite phase and skip the keys that has a timestamp > this fileld. no matter it's default or write cf.When set the
ignore_before_timestampthe sst will trigger the rewrite phase and skip the keys that has a timestamp < this fileld. on write cf.