Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configpb: revert changes to configpb as building with lower go version. #1293

Merged

Conversation

LykxSassinator
Copy link
Contributor

Description

Revert unnecessary changes to configpb introduced by https://github.com/pingcap/kvproto/pull/1291/files#diff-778439458ab010b5d2a619d82819b3a0a5b7bb2c117c3e7b4fdbf9aa0c2fb80cL23, built go deps with lower version on MacOS.

@ti-chi-bot ti-chi-bot bot added the size/S label Jan 17, 2025
@LykxSassinator
Copy link
Contributor Author

/cc @overvenus

@ti-chi-bot ti-chi-bot bot requested a review from overvenus January 17, 2025 04:32
Copy link

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-17 04:33:39.089003682 +0000 UTC m=+265890.544049831: ☑️ agreed by JmPotato.
  • 2025-01-17 04:35:27.398675235 +0000 UTC m=+265998.853721384: ☑️ agreed by overvenus.

@LykxSassinator
Copy link
Contributor Author

/check-label

@ti-chi-bot ti-chi-bot merged commit 258e68e into pingcap:master Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants