Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer: update read-timeout comment #1200

Merged
merged 4 commits into from
Jan 18, 2023
Merged

drainer: update read-timeout comment #1200

merged 4 commits into from
Jan 18, 2023

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #1169

What is changed and how it works?

Add read-timeout and its explanations on drainer's toml config.

Check List

Tests

  • None

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

@GMHDBJD @hi-rustin PTAL

shichun-0415
shichun-0415 reviewed Oct 18, 2022
View reviewed changes
@ti-chi-bot
Copy link
Member

@shichun-0415: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu @Rustin170506
Update cmd/drainer/drainer.toml
7dc0272 
Co-authored-by: 二手掉包工程师 <[email protected]>
GMHDBJD
GMHDBJD approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7dc0272

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 5aa2bdb into pingcap:master Jan 18, 2023
@lichunzhu lichunzhu deleted the updateBinlogComment branch January 18, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lichunzhu @ti-chi-bot @Rustin170506 @GMHDBJD @shichun-0415