Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(top_slowquery): implement the ui #1653

Merged
merged 12 commits into from
Mar 19, 2024
Merged

feat(top_slowquery): implement the ui #1653

merged 12 commits into from
Mar 19, 2024

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Mar 8, 2024

This PR implements the top slow query feature.

image

@ti-chi-bot ti-chi-bot bot requested a review from Renkai March 8, 2024 00:34
@ti-chi-bot ti-chi-bot bot added the size/XXL label Mar 8, 2024
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 413f566
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65f92ff6beb3ea000895f2c9
😎 Deploy Preview https://deploy-preview-1653--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.68%. Comparing base (aa6dbf6) to head (413f566).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1653      +/-   ##
==========================================
- Coverage   23.69%   23.68%   -0.02%     
==========================================
  Files         177      177              
  Lines       16043    16043              
==========================================
- Hits         3802     3800       -2     
- Misses      11956    11958       +2     
  Partials      285      285              
Flag Coverage Δ
backend_integration 8.99% <ø> (ø)
backend_ut 26.17% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa6dbf6...413f566. Read the comment docs.

Copy link
Member

@shhdgit shhdgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-19 06:48:40.162444138 +0000 UTC m=+1359347.184690525: ☑️ agreed by shhdgit.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mornyx, shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baurine baurine merged commit 530e463 into master Mar 19, 2024
14 of 15 checks passed
@baurine baurine deleted the feat/top-slow-query branch March 19, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants