Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyviz): support config, hide setting for clinic #1696

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Jul 2, 2024

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai July 2, 2024 04:58
@ti-chi-bot ti-chi-bot bot added the size/L label Jul 2, 2024
@baurine baurine force-pushed the feat/keyviz-app-config branch from f4c717e to 9d23822 Compare July 2, 2024 04:59
Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2024

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baurine baurine merged commit d33bfe8 into master Jul 2, 2024
6 of 7 checks passed
@baurine baurine deleted the feat/keyviz-app-config branch July 2, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants