Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update to golang 1.22 #1701

Closed
wants to merge 5 commits into from
Closed

Conversation

lance6716
Copy link

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai July 10, 2024 03:11
@CLAassistant
Copy link

CLAassistant commented Jul 10, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/L label Jul 10, 2024
@lance6716 lance6716 changed the title scripts: update mockery to support golang 1.22 *: update to golang 1.22 Jul 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2024

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please assign hundundm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Author

@mornyx many lint problems found. Pleaes help me to fix them 😢 You can push commits to this PR

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 26, 2024

When will we merge it?

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 26, 2024

It seems to be better to update to 1.21, which is consistent with PD

And we can update to 1.23 later

@baurine
Copy link
Collaborator

baurine commented Aug 1, 2024

Replaced by #1709 , so close this PR first.

@baurine baurine closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants