fix(group): fix unexpected rolling update when scale out/in #6053
Conversation
liubog2008
commented
Jan 26, 2025
liubog2008
commented
- replicas change unexpectedly changes the revision of instances.
- move the version field into the template struct
Signed-off-by: liubo02 <[email protected]>
|
/run-pull-e2e-kind-v2 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6053 +/- ##
==============================================
- Coverage 69.78% 69.74% -0.04%
==============================================
Files 153 153
Lines 9637 9638 +1
==============================================
- Hits 6725 6722 -3
- Misses 2912 2916 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
/lgtm |
|
@liubog2008: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fgksgf, liubog2008 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
