-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs br: fail the ebs volume backup when some backup member tc is invalid #6087
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6087 +/- ##
==========================================
+ Coverage 57.19% 62.60% +5.40%
==========================================
Files 259 269 +10
Lines 33233 46848 +13615
==========================================
+ Hits 19008 29329 +10321
- Misses 12291 15492 +3201
- Partials 1934 2027 +93
|
56813b4
to
ba1757b
Compare
/run-all-tests |
ba1757b
to
9756003
Compare
/run-all-tests |
/run-pull-e2e-kind-across-kubernetes |
/run-pull-e2e-kind-basic |
/run-pull-e2e-kind-tikv-scale-simultaneously |
Signed-off-by: BornChanger <[email protected]>
9756003
to
238c104
Compare
/run-all-tests |
/run-pull-e2e-kind |
@BornChanger: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created. In response to adding label named type/cherry-pick-for-release-1.5. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@BornChanger: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created. In response to adding label named type/cherry-pick-for-release-1.6. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Closes #6090
When some tidb cluster TC is invalid, its backup member goes into InvalidSpec status and fails. While the volumebackup status keeps as running.
What is changed and how does it work?
Let volume backup detect the failure of the backup member due to invalid tc and fail itself.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.