Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: fail the ebs volume backup when some backup member tc is invalid #6087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Feb 20, 2025

What problem does this PR solve?

Closes #6090

When some tidb cluster TC is invalid, its backup member goes into InvalidSpec status and fails. While the volumebackup status keeps as running.

What is changed and how does it work?

Let volume backup detect the failure of the backup member due to invalid tc and fail itself.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from shonge February 20, 2025 10:15
Copy link
Contributor

ti-chi-bot bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.60%. Comparing base (a16b2e8) to head (238c104).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6087      +/-   ##
==========================================
+ Coverage   57.19%   62.60%   +5.40%     
==========================================
  Files         259      269      +10     
  Lines       33233    46848   +13615     
==========================================
+ Hits        19008    29329   +10321     
- Misses      12291    15492    +3201     
- Partials     1934     2027      +93     
Flag Coverage Δ
e2e 46.47% <33.33%> (?)
unittest 55.80% <70.58%> (-1.39%) ⬇️

@BornChanger BornChanger force-pushed the invalid_ebs_bk_tc branch 2 times, most recently from 56813b4 to ba1757b Compare February 20, 2025 10:38
@BornChanger
Copy link
Contributor Author

/run-all-tests

@BornChanger
Copy link
Contributor Author

/run-all-tests

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-across-kubernetes

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-basic

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-tikv-scale-simultaneously

@BornChanger
Copy link
Contributor Author

/run-all-tests

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind

Copy link
Contributor

ti-chi-bot bot commented Feb 21, 2025

@BornChanger: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-1.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 21, 2025

@BornChanger: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-1.6.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid backup does not fail VolumeBackup
2 participants