Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TiKV RPC CLI and flush log backup tasks in graceful shutdown (#6057) #6101

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6057

What problem does this PR solve?

During rolling restart, the lag of log backup may be increased because progress lost of the restarted TiKV.

Closes #6046

What is changed and how does it work?

This added a gRPC Client to TiKV and manually triggered FlushNow when gracefully restarting a TiKV.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 23.36449% with 82 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (c23a794) to head (18f9050).
Report is 21 commits behind head on release-1.6.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.6    #6101      +/-   ##
===============================================
- Coverage        57.20%   57.00%   -0.20%     
===============================================
  Files              259      260       +1     
  Lines            33233    45149   +11916     
===============================================
+ Hits             19010    25739    +6729     
- Misses           12290    17420    +5130     
- Partials          1933     1990      +57     
Flag Coverage Δ
unittest 57.00% <23.36%> (-0.20%) ⬇️

@csuzhangxc csuzhangxc merged commit 194e030 into pingcap:release-1.6 Feb 28, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants