-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: add resource group name in stmt context #49422
Conversation
Hi @glorv. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
4af119d
to
7b19e7b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49422 +/- ##
================================================
+ Coverage 71.0551% 71.8820% +0.8268%
================================================
Files 1368 1423 +55
Lines 401291 431329 +30038
================================================
+ Hits 285138 310048 +24910
- Misses 96328 102419 +6091
+ Partials 19825 18862 -963
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, nolouch, tangenta, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/test pull-mysql-client-test |
@CabinfeverB: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #49318
Problem Summary:
What changed and how does it work?
In the current implementation, in order to support statement level hint /* +RESOURCE_GROUP(name) */ to execute a statement under specific resource group, we change the ResourceGroupName in session ctx during optimization and change back after the statement. This is currently done in the function
session.ExecuteStmt
(with a defer block). This life time may not be long enough as we have other operations such as query slow-log, query duration metrics, statement summary that depend on statement resource group but is run aftersession.ExecuteStmt
is finished.So this PR add a new field
ResourceGroupName
in StmtCtx and the /* Resource_Group() */ hint will change this filed isstead of directly change session context and this value can last until the next statement. The PR changes all statement related operation to use this field.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.