Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add new row panel for tidb query (#50086) #50321

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50086

What problem does this PR solve?

Issue Number: ref #49318

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
image

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.6 labels Jan 11, 2024
@bufferflies
Copy link
Contributor

/cc @nolouch @crazycs520

@ti-chi-bot ti-chi-bot bot requested review from crazycs520 and nolouch January 11, 2024 08:21
@bufferflies
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Jan 11, 2024

@bufferflies: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bufferflies
Copy link
Contributor

/test check-dev2

@bufferflies
Copy link
Contributor

/test mysql-test

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.6@a0ce8e0). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.6     #50321   +/-   ##
================================================
  Coverage               ?   70.0021%           
================================================
  Files                  ?       1436           
  Lines                  ?     419107           
  Branches               ?          0           
================================================
  Hits                   ?     293384           
  Misses                 ?     105413           
  Partials               ?      20310           
Flag Coverage Δ
unit 70.0021% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 49.6448% <0.0000%> (?)

Copy link

tiprow bot commented Jan 11, 2024

@bufferflies: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jan 11, 2024

@bufferflies: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 11, 2024
@bufferflies
Copy link
Contributor

/test check-dev2
/test mysql-test

Copy link

tiprow bot commented Jan 11, 2024

@bufferflies: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev2
/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bufferflies
Copy link
Contributor

/test check-dev2

Copy link

tiprow bot commented Jan 11, 2024

@bufferflies: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 11, 2024
@nolouch
Copy link
Member

nolouch commented Jan 11, 2024

/retest-required

Copy link

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 11, 2024
Copy link

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 13:13:50.679560162 +0000 UTC m=+535420.263813849: ☑️ agreed by nolouch.
  • 2024-01-11 13:15:11.611380454 +0000 UTC m=+535501.195634157: ☑️ agreed by crazycs520.

@ti-chi-bot ti-chi-bot bot merged commit e293f0d into pingcap:release-7.6 Jan 11, 2024
@bufferflies bufferflies deleted the cherry-pick-50086-to-release-7.6 branch January 12, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants