-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external: fix decoding the last key in split keys (#59613) #59747
base: release-8.1
Are you sure you want to change the base?
external: fix decoding the last key in split keys (#59613) #59747
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@CbcWestwolf This PR has conflicts, I have hold it. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CbcWestwolf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #59747 +/- ##
================================================
Coverage ? 71.2087%
================================================
Files ? 1468
Lines ? 424025
Branches ? 0
================================================
Hits ? 301943
Misses ? 101539
Partials ? 20543
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
This is an automated cherry-pick of #59613
What problem does this PR solve?
Issue Number: close #59725
Problem Summary:
When the kv size or kv count of unique key is large, we will call
GetRegionSplitKeys
, which did not properly consider the case ofkey.Next()
. Then it fails due to the decoding.What changed and how does it work?
Introduce the method
tryDecodeEndKey
to decode the last keyCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.