Skip to content

Commit

Permalink
Re-enable jemalloc's background thread by default (#9813) (#9814)
Browse files Browse the repository at this point in the history
ref #9722, close #9812

Re-enable jemalloc's background thread by default

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
3 people authored Jan 23, 2025
1 parent 3034774 commit 65a91a3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions dbms/src/Server/Server.cpp
Original file line number Diff line number Diff line change
@@ -379,10 +379,10 @@ void UpdateMallocConfig([[maybe_unused]] const LoggerPtr & log)
RUN_FAIL_RETURN(je_mallctl("opt.background_thread", (void *)&old_b, &sz_b, nullptr, 0));
RUN_FAIL_RETURN(je_mallctl("opt.max_background_threads", (void *)&old_max_thd, &sz_st, nullptr, 0));

LOG_INFO(log, "Got jemalloc config: opt.background_thread {}, opt.max_background_threads {}", old_b, old_max_thd);

if (!malloc_conf && !old_b)
bool not_config_bg = !malloc_conf || strstr(malloc_conf, "background_thread") == nullptr;
if (not_config_bg && !old_b)
{
// If the user doesn't explicitly set the background_thread opt, and it is actually false, then set it to true.
LOG_INFO(log, "Try to use background_thread of jemalloc to handle purging asynchronously");

RUN_FAIL_RETURN(je_mallctl("max_background_threads", nullptr, nullptr, (void *)&new_max_thd, sz_st));

0 comments on commit 65a91a3

Please sign in to comment.