Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pre_exec in Proxy #5386

Merged
merged 13 commits into from
Jul 19, 2022
Merged

Support pre_exec in Proxy #5386

merged 13 commits into from
Jul 19, 2022

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jul 15, 2022 •
edited
Loading

Signed-off-by: CalvinNeo [email protected]

What problem does this PR solve?

Issue Number: ref #5170

Problem Summary:

  1. Support pre_exec in Proxy
  2. Filter CompactLog if a prelim flush fails
  3. Always filter ComputeHash and VerifyHash

We also use a isolated Proxy branch here for easier rollback when failure.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
i
b0d4a23 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2022
@CalvinNeo
f
4f0e79d 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@CalvinNeo
f
abb1aba 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
f
f77b788 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
f
f028ddf 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

/cc @JaySon-Huang @lidezhu

@CalvinNeo
comment
8b4f49a 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
d
91e15f7 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
f
66dce1b 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2022
lidezhu
lidezhu approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@JaySon-Huang
Copy link
Contributor

Could we return an enum value {Done/Skip} instead of boolean for AdminObserver:: pre_exec_admin/QueryObserver:: pre_exec_query?

pingcap/tidb-engine-ext@fbd8e6f...e83a37d#diff-6342e87aaabe7cc62e18d32b39683f4db7c3566756769c6d2c296188d40bd805R90-R93

@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

Could we return an enum value {Done/Skip} instead of boolean for AdminObserver:: pre_exec_admin/QueryObserver:: pre_exec_query?

pingcap/tidb-engine-ext@fbd8e6f...e83a37ddiff-6342e87aaabe7cc62e18d32b39683f4db7c3566756769c6d2c296188d40bd805R90-R93

LGTM. However, we'd better use this solution for now.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 18, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       407                80    80.34%          43                 3    93.02%         676                87    87.13%         218                79    63.76%
tests/gtest_kvstore.cpp          3791               752    80.16%          28                 2    92.86%        1308                31    97.63%        1126               597    46.98%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4198               832    80.18%          71                 5    92.96%        1984               118    94.05%        1344               676    49.70%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18576      9573             48.47%    210693  96382        54.25%

full coverage report (for internal network access only)

JaySon-Huang
JaySon-Huang approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2022
@CalvinNeo
Copy link
Member Author

/hold need update some mock and tests

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@CalvinNeo
add some tests and mock
ada329b 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ada329b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2022
@CalvinNeo
Copy link
Member Author

/hold seem not updated

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@CalvinNeo
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@CalvinNeo
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@CalvinNeo
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 19, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       407                80    80.34%          43                 3    93.02%         676                87    87.13%         218                79    63.76%
tests/gtest_kvstore.cpp          3791               752    80.16%          28                 2    92.86%        1308                31    97.63%        1126               597    46.98%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4198               832    80.18%          71                 5    92.96%        1984               118    94.05%        1344               676    49.70%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18618      9409             49.46%    212185  95013        55.22%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 19, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       407                80    80.34%          43                 3    93.02%         676                87    87.13%         218                79    63.76%
tests/gtest_kvstore.cpp          3791               752    80.16%          28                 2    92.86%        1308                31    97.63%        1126               597    46.98%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4198               832    80.18%          71                 5    92.96%        1984               118    94.05%        1344               676    49.70%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18618      9409             49.46%    212185  94971        55.24%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit e737618 into pingcap:master Jul 19, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 19, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       407                80    80.34%          43                 3    93.02%         676                87    87.13%         218                79    63.76%
tests/gtest_kvstore.cpp          3791               752    80.16%          28                 2    92.86%        1308                31    97.63%        1126               597    46.98%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4198               832    80.18%          71                 5    92.96%        1984               118    94.05%        1344               676    49.70%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18618      9406             49.48%    212185  95009        55.22%

full coverage report (for internal network access only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@hehechen hehechen hehechen approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CalvinNeo @ti-chi-bot @JaySon-Huang @sre-bot @hehechen @lidezhu