-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy: Decouple prehandle snapshot from RegionWorker #5720
Conversation
Signed-off-by: CalvinNeo <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d433530
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
Signed-off-by: CalvinNeo [email protected]
What problem does this PR solve?
Issue Number: ref #5170
Problem Summary:
TiFlash Proxy used to reuse RegionWorker to prehandle snapshot. In this PR, we move the prehandle and apply snapshot procedure out of raftstore to our observer. The whole process remain the same, excluding:
A simple "flow control" mechanism which aims to make full utilization of pre handle thread pool is still in raftstore and will be removed in the future.
We also use a independent branch to test this.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note