Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka(ticdc): sarama do not retry if produce message failed to prevent out of order #11977

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11935

What is changed and how it works?

  • config.Net.MaxOpenRequest is set to 1
  • config.Producer.Retry.Max is set to 0, to disable the internal retry mechanism

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

This is tested by an internal E2E test, which inject network partition between the random cdc node and random kafka server. Before this PR, the test case cannot be passed, and we found out-of-order message by reading consumer log, after this PR it can be passed, and no out-of-order message.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

fix the sarama retry caused out-of-order message by set retry count to 0 as a workaround

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 6, 2025
@3AceShowHand 3AceShowHand changed the base branch from master to release-7.5-20250106-v7.5.4 January 6, 2025 02:50
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 6, 2025
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand 3AceShowHand removed affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. labels Jan 6, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 6, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-06 02:54:11.715617499 +0000 UTC m=+149395.004449203: ☑️ agreed by wk989898.
  • 2025-01-06 03:02:09.020106515 +0000 UTC m=+149872.308938223: ☑️ agreed by asddongmen.

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0cf6d84 into pingcap:release-7.5-20250106-v7.5.4 Jan 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sarama produces messages in out-of-order when retries happen
3 participants